Azure/ng-deploy-azure

Use SDK for E2E tests

Open

#50 opened on Aug 18, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (43 forks)github user discovery
bugenhancementhelp wanted

Repository metrics

Stars
 (79 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug When running the e2e test, the script uses az - the Azure CLI to clean up the resources. However, we can't expect all developers of ng deploy to have the Azure CLI installed. The cleanup should be done using the resources that are already available - the SDKs that are used in the project.

Error: ./scripts/test.sh: line 44: az.cmd: command not found To Reproduce Steps to reproduce the behavior:

  1. If you have Azure CLI, uninstall it. (Run az to see that it's not available)
  2. Run npm run test:e2e
  3. If the tests run as expected, after getting the link of the website, it crashes with the error message above.
  4. Click on the link - it opens the website. Meaning the resources were not cleared.

Expected behavior 3 - the test script should not crash. 4 - the link should not be available.

Contributor guide

Research direction
Replace Azure CLI commands in the e2e test script with equivalent SDK calls using the @azure/identity and @azure/arm resources packages.
Tech stack
typescriptangularazurenodejs
Domain
testingdevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsAzure SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75