validate resource name before deployment

Open
#69 5 comments 0 reactions 1 assignee View on GitHub

@DCMattyG is already working on this.

Since Jan 15, 2023.

Assessment

This issue has not been assessed yet.

Description

enhancement

Describe the bug
If name prefix is longer than 7 character deployment will fail on Keyvault step but RG, LAW and MI is created.

documentation not specifying what is allowed here.
-NamePrefix | Replaces the default resource prefix of "ipam" with an alternative prefix

To Reproduce
Deploy IPAM with parameter -NamePrefix "ipam-test" `

Expected behavior
Successful deployment

Screenshots
If applicable, add screenshots to help explain your problem.

Result:
Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details. (Code: DeploymentFailed)

  • {
    "error": {
    "code": "VaultNameNotValid",
    "message": "The vault name 'ipam-test-kv-2jhngm4kxwuh4' is invalid. A vault's name must be between 3-24 alphanumeric characters. The name must begin with a letter, end with a letter or digit, and not contain consecutive hyphens. Follow this link for more information: https://go.microsoft.com/fwlink/?linkid=2147742"
    }
    } (Code:BadRequest)

i recommend either to change naming standard for kv or stop deployment script before bicep deployment mode.
It's not a blocer but nice to have feature ;)

Dominant language
JavaScript
Stars
327
Forks
111
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Azure/ipam

All issues in Azure/ipam

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.