com_wrapper should return THANDLE(s) instead of manually refcounted objects
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
No files, tests, or entry points are named. Start by locating com_wrapper and the THANDLE definition, then trace the current AddRef and Release ownership behavior. Done means the proposed return type and ownership semantics are consistently applied, with the manual reference-counting interface removed.
Written by the indexing model from the issue text.
Description
It is all nice when the vtbl has AddRef and Release, but here the proposal is to remove those and have com_wrapper return a THANDLE.
The benefit here is that a THANDLE has "forced" semantics, while a IUnknown has "by convention and good attention of developer" semantics.
- Dominant language
- C
- Stars
- 2
- Forks
- 9
- Avg merge
- 34m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
os:linux
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
mpv-player/mpv#18510 · 2 comments ·
-
internal.h中，漏掉了1个定义。 Open
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
kovidgoyal/kitty#10516 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 80/100