Azure/azure-powershell

Get-AzSubscription command should display warning or fail if non-default tenant id is given when MSi auth is being used

Open

#25,710 opened on Jul 31, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PowerShell (4,102 stars) (3,744 forks)batch import
AuthenticationAzure PS TeamTrackingbugcustomer-reportedgood first issue

Description

Description

This issue happens only whan managed service identity is being used.

If user input tenant id that does not match with the Default Context tenant id command silently ignore usser input and does nothing:

https://github.com/Azure/azure-powershell/blob/b60bd252c86a5459ab28476651fd45f8810e839f/src/Accounts/Accounts/Subscription/GetAzureRMSubscription.cs#L109-L121

When using other authentication methods -tenantId allows using tenant name. For script portability that should also be supported with managed service authentication.

If usage of the tenant names cannot be used with managed service authentication command should at least warn about unexpected input instead on silently doing nothing.

Issue script & Debug output

N/A

Environment data

PS /home/janne> $PSVersionTable                                           

Name                           Value
----                           -----
PSVersion                      7.4.3
PSEdition                      Core
GitCommitId                    7.4.3
OS                             CBL-Mariner/Linux
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Module versions

ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Script     3.0.1                 Az.Accounts                         {Add-AzEnvironment, Clear-AzConfig, Clear-AzContext, Clear-AzDefault…}
Script     8.1.0                 Az.Compute                          {Add-AzImageDataDisk, Add-AzVhd, Add-AzVMAdditionalUnattendContent, Add-AzVMD…
Script     7.8.0                 Az.Network                          {Add-AzApplicationGatewayAuthenticationCertificate, Add-AzApplicationGatewayB…
Script     7.2.0                 Az.Resources                        {Export-AzResourceGroup, Export-AzTemplateSpec, Get-AzDenyAssignment, Get-AzD…
Script     7.1.0                 Az.Storage                          {Add-AzRmStorageContainerLegalHold, Add-AzStorageAccountManagementPolicyActio…
Script     1.1.3                 Az.Tools.Predictor                  {Disable-AzPredictor, Enable-AzPredictor, Open-AzPredictorSurvey, Send-AzPred…
Script     0.0.0.10              AzureAD.Standard.Preview            {Add-AzureADApplicationOwner, Add-AzureADDeviceRegisteredOwner, Add-AzureADDe…
Script     0.9.3                 AzurePSDrive

Error output

N/A

Contributor guide

Tech stack
csharp
Domain
authenticationapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of Azure PowerShellFamiliarity with managed service identity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests that `Get AzSubscription` should either warn or fail when a non default tenant ID is provided while using managed service identity (MSI) authentication. The relevant code is in `src/Accounts/Accounts/Subscription/GetAzureRMSubscription.cs` around line 109. The fix could involve adding a check for tenant ID mismatch and either logging a warning or throwing an error. Additionally, supporting tenant names with MSI would require more investigation into Azure authentication flows. The maintainers should clarify whether a warning or error is preferred.