security-definitions-structure-validation.md has incorrect description

Open Beginner friendly
#235 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
65/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
markdown
Domain
documentation

Research direction

Open docs/security-definitions-structure-validation.md at the referenced line and compare its description with the validation example in the issue. Run autorest --validation --azure-validator readme.md with the provided securityDefinitions snippet; done means the description and validator expectation match without the incompatible-values error.

Written by the indexing model from the issue text.

Description

https://github.com/Azure/azure-openapi-validator/blame/master/docs/security-definitions-structure-validation.md#L11 should have a period at the end.

Running autorest --validation --azure-validator readme.md with

...
"securityDefinitions": {
    "azure_auth": {
      "type": "oauth2",
      "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize",
      "flow": "implicit",
      "description": "Azure Active Directory OAuth2 Flow",
      "scopes": {
        "user_impersonation": "impersonate your user account"
      }
    }
  }
...

gives

Error: '$.securityDefinitions.azure_auth.description' has incompatible values (---
Azure Active Directory OAuth2 Flow.
, ---
Azure Active Directory OAuth2 Flow
).

Changing
"description": "Azure Active Directory OAuth2 Flow"
to
"description": "Azure Active Directory OAuth2 Flow."
solves the issue

Dominant language
TypeScript
Stars
53
Forks
57
Avg merge
1d 23h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Azure/azure-openapi-validator

All issues in Azure/azure-openapi-validator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.