Typo on references to json boolean values on https://github.com/Azure/azure-linux-extensions/tree/master/VMAccess
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 62/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- documentation
Research direction
Open the VMAccess references page linked in the issue and review the examples for check_disk and reset_ssh. Correct the boolean examples by removing the double quotes and ensure the surrounding explanation matches JSON boolean behavior; done means the page no longer presents these values as strings.
Written by the indexing model from the issue text.
Description
References on VMAccess like:
"check_disk": "false"
"reset_ssh": "false"
Should not have double quotes since they are boolean values.
On JSON boolean values a non empty string is considered true so "False" of being considered as false is considered as true
This leads to, as an example, "check_disk" : "false" actually triggering a fsck causing the extension deployment to fail with "Check Failed" because fsck command fails due to the data disks being mounted and "reset_ssh" : "False" will in fact reset the ssh daemon configuration to be reset.
- Dominant language
- Python
- Stars
- 333
- Forks
- 277
- Avg merge
- 5d 1h
- Merged PRs (30d)
- 5
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Azure/azure-linux-extensions
-
bug extensions/OSPatching
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Azure/azure-linux-extensions#416 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
Azure/azure-linux-extensions#2208 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 68/100
Azure/azure-linux-extensions#2200 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Azure/azure-linux-extensions#2191 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Azure/azure-linux-extensions#2173 · 6 comments · 14 reactions ·
All issues in Azure/azure-linux-extensions
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100