[Question] Dependecy resolvement when specifying custom configuration
@guythetechie is already working on this.
Since Sep 18, 2024.
Assessment
This issue has not been assessed yet.
Description
Release version
v6.0.1.1
Question Details
Problem Description
Publishing a policy fragment depending on the named value results in the following error:
info: publisher[0]
Putting policy policy for operation dependecycheck in API echo-api...
info: publisher[0]
Putting policy policy for operation retrieve-header-only in API echo-api...
crit: publisher[0]
Application failed.
System.Net.Http.HttpRequestException: HTTP request to URI https://management.azure.com/subscriptions/***/resourceGroups/app-grp/providers/Microsoft.ApiManagement/service/api-grp-apim-3/apis/echo-api/operations/dependecycheck/policies/policy?api-version=2023-09-01-preview failed with status code 400. Content is '{"error":{"code":"ValidationError","message":"One or more fields contain incorrect values:","details":[{"code":"ValidationError","target":"include-fragment","message":"Error in element 'include-fragment' on line 11, column 4: Policy fragment with id 'TokenValidator' could not be found."}]}}'.
Environment setup
The solution uses the following features from API Management:
- APIs
- Named Values
- Policy Fragments
The relationships are:
- named values contain properties
- policy depends on the name value
- the policy is attached to the API
The policy content - to understand the correlation with named values:
<fragment>
<validate-jwt header-name="Authorization" failed-validation-httpcode="401" failed-validation-error-message="User not authenticated" require-expiration-time="true" require-scheme="Bearer" require-signed-tokens="true" output-token-variable-name="token_customer_info">
<openid-config url="https://{{my_idp_hostname}}/.well-known/openid-configuration" />
<audiences>
<audience>https://{{my_idp_hostname}}/api/v2/</audience>
<audience>https://{{my_idp_hostname}}/userinfo</audience>
</audiences>
<issuers>
<issuer>https://{{my_idp_hostname}}/</issuer>
</issuers>
<required-claims>
<claim name="{{my_namespace}}/customer_id" match="all" />
</required-claims>
</validate-jwt>
</fragment>
Example of configuration file per e.g. Prod:
`
apimServiceName: api-prod
namedValues:
- name: MyIdpHostname
properties:
displayName: my_idp_hostname
value: "<enter_your_prod_idp>"
`
The publishing pipeline has 3 stages:
- dev; to republish what we have in git
- uat, we read what we have in git, make amendments to named values (see above), and publish it
- prod, we read what we have in git, make amendments to named values (see above), and publish it
During the publishing test, we observed the following behavior:
- API is published
- Policy publishing fails
Observations
- The policy is published when the configuration file is not specified.
- Named values are replaced, but only if they are not available.
NB: This applies when we have a custom configuration file to amend values per stage/environment. The same behavior/outcome applies to Products; whether we use partial (publish-artifacts-in-last-commit) or full publishing (publish-all-artifacts-in-repo).
Questions
- Named Value: why can we not replace/amend the value if previously available?
- Dependencies: why does a replacement of NamedValue work if not previously available, but the policy referencing it, fails?
Is this by design or perhaps a bug?
Thanks in advance.
Expected behavior
Named values are replaced
Named values are published
API is published
Policy is published
API is updated
Actual behavior
Named values are replaced
Named values are published (only if not available earlier)
API is published
Policy publishing fails with status code 400:
crit: publisher[0]
Application failed.
System.Net.Http.HttpRequestException: HTTP request to URI https://management.azure.com/subscriptions/***/resourceGroups/app-grp/providers/Microsoft.ApiManagement/service/api-grp-apim-3/apis/echo-api/operations/dependecycheck/policies/policy?api-version=2023-09-01-preview failed with status code 400. Content is '{"error":{"code":"ValidationError","message":"One or more fields contain incorrect values:","details":[{"code":"ValidationError","target":"include-fragment","message":"Error in element 'include-fragment' on line 11, column 4: Policy fragment with id 'TokenValidator' could not be found."}]}}'.
Reproduction Steps
Prerequisites:
- Use Echo API (by default available when an instance of API Management is created)
Steps:
- Create a policy (see above)
- Assign the policy to Echo API; it does not matter what API endpoint.
- Run executor (no filter configuration attached)
- Run publisher (with configuration example as specified above).
Publisher fails.
PS: The same behavior is observed with Products.
- Dominant language
- C#
- Stars
- 448
- Forks
- 247
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Azure/apiops
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 70/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1425 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Documentation
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cake-build/cake#5024 ·
-
Frontend status/draft TechnicalDebt
Difficulty 2/5 1-2 days Newbie friendliness 75/100
Altinn/altinn-auth#4143 ·