`cancelRequest(withId:)` is entirely compiled out where Combine is unavailable

Open Beginner friendly
#1,519 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
swift
Domain
api

Research direction

Start in native/swift/Sources/wordpress-api/SafeRequestExecutor.swift around line 152 and trace cancelRequest(withId:) and cancel(context:), including the session.allTasks lookup and task cancellation. Verify the Linux/non-Combine build, and consider the issue done when cancellation still runs without Combine and produces CancellationError.

Written by the indexing model from the issue text.

Description

Bug Error Handling Swift

Split out from Automattic/wordpress-rs#1497 — Swift executor URLSession error audit. Section E — Cancellation gaps.

File references are to native/swift/Sources/wordpress-api/SafeRequestExecutor.swift unless noted; :NNN line numbers were verified against fix/converge-executor-error-classification.

Severity: low. The whole body sits inside #if canImport(Combine) (:152), including the session.allTasks lookup and task?.cancel() that need no Combine — only the notification fallback does. On Linux, cancel(context:) therefore cancels nothing, ever, and cancellation never produces CancellationError. Scope the #if to just the publisher fallback.

Dominant language
Rust
Stars
36
Forks
5
Avg merge
16h 5m
Merged PRs (30d)
39

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/wordpress-rs

All issues in Automattic/wordpress-rs

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.