Use Gutenberg's native `anchor` support for setting the pym parent element ID

Open
#36 2 comments 0 reactions 1 assignee View on GitHub

@claudiulodro is already working on this.

Since Sep 21, 2020.

Assessment

This issue has not been assessed yet.

Description

gutenberg

We didn't do this in the initial implementation of Gutenberg blocks in #34 because, at the time, it appeared as if there was no way to use Gutenberg's anchor property with a block that was dynamically rendered.

For more history, see the following comments:

Elements of this ticket:

  • remove the shim introduced in #34
  • add a supports declaration for anchor
  • add the anchor output to the pym_shortcode function.
Dominant language
PHP
Stars
15
Forks
8
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/pym-shortcode

All issues in Automattic/pym-shortcode

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.