Automattic/pocket-casts-ios

i18n: Episode Errors are stored as user displayed strings

Open

#9 opened on Jul 11, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (1,789 stars) (180 forks)user submission
[Feature] Podcast Details[Type] Buggood first issuei18n

Description

Changing the language on the device will retain the message in the previous language.

  1. Set the device to a specific language
  2. Generate an episode error by taking the device offline and then attempting to play an episode that hasn't been downloaded.
  3. Switch to a new language
  4. Notice that the error is still in the previous language.

Contributor guide

Tech stack
swift
Domain
mobileinternationalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftiOS localization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how episode error messages are stored in the Pocket Casts iOS app. Look for string literals used for error displays, likely in files related to episode playback error handling. Ensure that these strings are wrapped in NSLocalizedString to support dynamic language changes, and that the error objects or view controllers refresh their displayed strings when the device language changes.
i18n: Episode Errors are stored as user displayed strings · Automattic/pocket-casts-ios#9 | Good First Issue