Automattic/pocket-casts-ios

i18n: Episode Errors are stored as user displayed strings

Open

#9 opened on Jul 11, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (180 forks)user submission
[Feature] Podcast Details[Type] Buggood first issuei18n

Repository metrics

Stars
 (1,789 stars)
PR merge metrics
 (Avg merge 2d 2h) (197 merged PRs in 30d)

Description

Changing the language on the device will retain the message in the previous language.

  1. Set the device to a specific language
  2. Generate an episode error by taking the device offline and then attempting to play an episode that hasn't been downloaded.
  3. Switch to a new language
  4. Notice that the error is still in the previous language.

Contributor guide

Research direction
Investigate where episode error messages are stored and ensure they are dynamically localized using NSLocalizedString, not cached in the previous language. Look for any persistent storage of error strings and update them when the device language changes.
Tech stack
swiftios
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftiOS localization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65