push-md: e2e suite only exercises the unscoped source, not the built (scoped) zip
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 68/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- bash, docker, git, github-actions, php
- Domain
- build-system, ci-cd, testing
Research direction
Start with bin/build-plugins.sh, bin/run-push-md-playground.sh, bin/inspect-push-md-zip.sh, and the existing push-md-e2e.yml workflow to trace how the current source-mounted flow is built and run. Add a fresh Playground path that installs dist/plugins/push-md.zip, then run the existing clone, Markdown edit, commit, and push flow. Done means the scoped artifact is functionally loaded, the push succeeds without a fatal or bad line length character error, and the artifact path runs in CI.
Written by the indexing model from the issue text.
Description
Summary
The push-md e2e suite never functionally imports the built (scoped) plugin zip — it mounts the unscoped source tree directly. This is the testing gap that let the scoping regression in #68 (fixed by #69) ship in v0.6.6 / v0.6.7 uncaught: clone worked, but the first Markdown import/push fataled on the scoped build, and no automated test loaded the scoped artifact.
Details
bin/run-push-md-playground.sh boots Playground against the live source, not the release artifact:
--mount="$ROOT_DIR:/workspace"
--mount="$ROOT_DIR/vendor:/wordpress/wp-content/vendor"
--mount="$ROOT_DIR/components:/wordpress/wp-content/components"
--mount="$ROOT_DIR/plugins/push-md:/wordpress/wp-content/plugins/push-md"
So the e2e flow runs with:
- the unscoped namespaces (
Nette\…,League\…, …), where inline qualified references resolve fine, and - the dev bootstrap / composer autoloader, not the generated/scoped
php-toolkit/vendor/composer/*classmap.
bin/build-plugins.sh produces the scoped dist/plugins/push-md.zip, but it's only checked structurally by bin/inspect-push-md-zip.sh (file presence + content greps). Nothing ever loads the scoped classes through their autoloader and pushes Markdown, so a scoping bug that fatals at class-load time passes every gate.
Proposed follow-up
Add an e2e path that exercises the built zip:
bash bin/build-plugins.shto producedist/plugins/push-md.zip.- Install that zip on a fresh Playground site (a blueprint step that installs the artifact, rather than mounting source).
- Run the existing import/push flow:
git clone …/wp-json/git/v1/md.git, edit apost/*.md, commit,git push. - Assert success (no
bad line length character: <br, no PHP fatal in the receive-pack response).
Wire this into CI (e.g. push-md-e2e.yml) so every change that touches the scoper, prune list, or bundle layout is validated against the shipped artifact.
Notes
- #69 already adds a cheap static canary in
inspect-push-md-zip.sh(rejects in-class traituseof a scoped name missing a leading backslash). This issue is about the functional gate that a static grep can't cover. - Keep the unscoped-source e2e too (fast inner loop); the scoped-zip run is the release-artifact gate.
Follow-up to #69 / #68.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/php-toolkit
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Automattic/php-toolkit#89 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Automattic/php-toolkit#102 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
Automattic/php-toolkit#95 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Automattic/php-toolkit#91 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Automattic/php-toolkit#88 ·
All issues in Automattic/php-toolkit
Similar issues
-
Solved site promotion gate fails on runner PHP patch drift (expects 8.2.33, runner installs 8.2.34) Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Automattic/blocks-engine#2161 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/static-site-importer#1824 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100