Automattic/node-canvas

refactor font registration API

Open

#245 opened on Jan 16, 2013

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (9,524 stars) (1,140 forks)batch import
FeatureHelp wantedsemver-major

Description

var pfennigFont = new Font('pfennigFont', fontFile('Pfennig.ttf'));
pfennigFont.addFace(fontFile('PfennigBold.ttf'),   'bold');
pfennigFont.addFace(fontFile('PfennigItalic.ttf'), 'normal', 'italic');
pfennigFont.addFace(fontFile('PfennigBoldItalic.ttf'), 'bold', 'italic');

to something like:

canvas
  .font('file.ttf', 'name')
  .face('file-bold.ttf', 'bold')
  .face('file-italic.ttf', 'normal', 'italic')

Contributor guide

Tech stack
nodejsjavascript
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Node.jsUnderstanding of canvas font API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the current Font class implementation in node canvas source code (likely in lib/canvas.js or src/Font.cc). Review the issue comments for any prior attempts or design discussions. Verify if the proposed chaining API remains relevant given potential library updates since 2013. Check if there are any existing PRs or branches addressing this refactor.