Automattic/node-canvas

fillStyle and strokeStyle fail when using fractional values on rgba

Open

#1,787 opened on Apr 19, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,140 forks)batch import
BugGood first issue

Repository metrics

Stars
 (9,524 stars)
PR merge metrics
 (Avg merge 34d 18h) (2 merged PRs in 30d)

Description

Issue or Feature

Whenever you try to set a color style with fractional components like 'rgba(120.1, 120.2, 120.3, 1)', it fails to parse and defaults to a black color.

Steps to Reproduce

var Canvas = require('canvas');
var canvas = Canvas.createCanvas(200, 200);
var ctx = canvas.getContext('2d');
ctx.fillStyle = 'rgba(240.2,0,0,1)';
ctx.fillRect(20, 20, 40, 40);

Shows a black rectangle instead of a red one.

Your Environment

node-canvas 2.7.0 Node is v12.16.1 on OS X Catalina 10.15.7

Contributor guide

Research direction
Examine the color parsing code in the node canvas source, specifically the function that handles rgba strings. Test with fractional values like 'rgba(120.1, 120.2, 120.3, 1)' and identify why they fail to parse correctly.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75