Automattic/node-canvas

Support for color values with percentage representation ?

Open

#1,391 opened on Mar 22, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,140 forks)batch import
FeatureHelp wanted

Repository metrics

Stars
 (9,524 stars)
PR merge metrics
 (Avg merge 34d 18h) (2 merged PRs in 30d)

Description

Issue or Feature

The current implementation looks like ignoring color value with percentage representations rgba(100%,100%,100%,1.0). It is valid css color value according to this document. Is there any plan for supporting this or am I overlooking something ?

A library I am using outputs with this format and I am stuck here :S

Your Environment

  • Version of node-canvas (output of npm list canvas or yarn list canvas): canvas@2.4.1
  • Environment (e.g. node 4.2.0 on Mac OS X 10.8): Mac OS X 10.4.3

Contributor guide

Research direction
Examine the color parsing code in node canvas, likely in the lib/color.js or similar file. Identify where CSS color strings are parsed and add support for percentage values in rgba(), hsla(), etc. Follow the existing pattern for fixed values and extend it to handle percentages.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS color knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70