Automattic/node-canvas

Async context isn't propagated correctly

Open

#1333 opened on Dec 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (9,524 stars) (1,140 forks)batch import
BugHelp wanted

Description

See https://github.com/node-serialport/node-serialport/issues/1742#issuecomment-448721788 and later comments.

(I think this is minor impact. Just happened to come up in another module.)

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Node.js async hooks understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Research the linked issue and comments to understand the specific async context propagation problem. Review the node canvas source code for any usage of async hooks or context propagation. Identify where the context is lost and propose a fix. Engage with maintainers for clarification on expected behavior.