Automattic/node-canvas

Async context isn't propagated correctly

Open

#1,333 opened on Dec 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,140 forks)batch import
BugHelp wanted

Repository metrics

Stars
 (9,524 stars)
PR merge metrics
 (Avg merge 34d 18h) (2 merged PRs in 30d)

Description

See https://github.com/node-serialport/node-serialport/issues/1742#issuecomment-448721788 and later comments.

(I think this is minor impact. Just happened to come up in another module.)

Contributor guide

Research direction
Investigate the referenced issue and comments to understand the async context propagation problem in node canvas. Trace the code paths where async operations might lose context.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30