Automattic/monk

Manager._state not updated after reconnect

Open

#293 opened on Feb 7, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,847 stars) (202 forks)batch import
bughelp wanted

Description

When following events are emitted:

  • open
  • close
  • reconnect The connection _state parameter is still STATE.CLOSED from the close event.

This because when a reconnect event is emitted by the MongoClient, the Manager _state parameter isn't updated to STATE.OPEN.

Contributor guide

Tech stack
javascriptnodejsmongodb
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsevent handlingMonk library structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate Manager.js file, specifically the event listeners for 'open', 'close', and 'reconnect'. The issue states that after 'close' sets state to STATE.CLOSED, the subsequent 'reconnect' event does not update it back to STATE.OPEN. Look at how the reconnect handler is implemented and ensure it sets state appropriately. Check for any comments or linked PRs; none exist. The fix likely involves adding a state update in the reconnect listener.