Subscription dark background

Open
#261 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
wordpress
Domain
frontend

Research direction

Start with the linked preview and the supplied block markup, focusing on the heading's Domine font declaration and how custom fonts appear on the Blockpatterns site. Compare the rendered heading with the intended pattern; done means the custom heading font renders correctly in the preview.

Written by the indexing model from the issue text.

Description

Screenshot:
image

<!-- wp:cover {"url":"https://dotcompatterns.files.wordpress.com/2022/08/bookimg.jpg","id":6069,"dimRatio":0,"minHeight":60,"minHeightUnit":"vh","isDark":false,"align":"wide","style":{"spacing":{"padding":{"bottom":"40px","top":"40px"}}}} -->
<div class="wp-block-cover alignwide is-light" style="padding-top:40px;padding-bottom:40px;min-height:60vh"><span aria-hidden="true" class="wp-block-cover__background has-background-dim-0 has-background-dim"></span><img class="wp-block-cover__image-background wp-image-6069" alt="" src="https://dotcompatterns.files.wordpress.com/2022/08/bookimg.jpg" data-object-fit="cover"/><div class="wp-block-cover__inner-container"><!-- wp:group {"style":{"color":{"text":"#fffffa"}},"layout":{"inherit":true}} -->
<div class="wp-block-group has-text-color" style="color:#fffffa"><!-- wp:group {"style":{"spacing":{"padding":{"top":"30px","right":"30px","bottom":"30px","left":"30px"}}}} -->
<div class="wp-block-group" style="padding-top:30px;padding-right:30px;padding-bottom:30px;padding-left:30px"><!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap"}} -->
<div class="wp-block-group"><!-- wp:image {"id":6109,"width":100,"height":100,"sizeSlug":"large","linkDestination":"none"} -->
<figure class="wp-block-image size-large is-resized"><img src="https://dotcompatterns.files.wordpress.com/2022/08/girl-avatar.png?w=200" alt="" class="wp-image-6109" width="100" height="100"/></figure>
<!-- /wp:image --></div>
<!-- /wp:group -->

<!-- wp:heading {"style":{"typography":{"fontStyle":"normal","fontWeight":"600","fontSize":"4rem"}},"fontFamily":"domine"} -->
<h2 class="has-domine-font-family has-custom-font" style="font-size:4rem;font-style:normal;font-weight:600;font-family:domine">Of books &amp; literature</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Weekly newsletter for the great reads and book suggestions from the New York times best sellers curator.</p>
<!-- /wp:paragraph -->

<!-- wp:jetpack/subscriptions {"buttonWidth":"","submitButtonText":"\u003cstrong\u003e Subscribe\u003c/strong\u003e","customButtonBackgroundColor":"#fffffa","customTextColor":"#3a2325","borderRadius":0,"borderWeight":0,"customBorderColor":"#fffffa","padding":15,"spacing":20,"className":"is-style-split"} -->
<div class="wp-block-jetpack-subscriptions wp-block-jetpack-subscriptions__supports-newline is-style-split">[jetpack_subscription_form show_subscribers_total="false" button_on_newline="false" submit_button_text="&lt;strong&gt; Subscribe&lt;/strong&gt;" custom_background_button_color="#fffffa" custom_text_button_color="#3a2325" custom_font_size="16px" custom_border_radius="0" custom_border_weight="1" custom_border_color="#fffffa" custom_padding="15" custom_spacing="20" submit_button_classes="no-border-radius" email_field_classes="no-border-radius" show_only_email_and_button="true" success_message="Success! An email was just sent to confirm your subscription. Please find the email now and click &#039;Confirm Follow&#039; to start subscribing."]</div>
<!-- /wp:jetpack/subscriptions --></div>
<!-- /wp:group --></div>
<!-- /wp:group --></div></div>
<!-- /wp:cover -->

Somehow the custom fonts for headings are not rendering in the Blockpatterns site. @alaczek do you have any info on this?

Preview:
https://dotcompatterns.wordpress.com/?p=6067&preview=true

Dominant language
No language data
Stars
7
Forks
2
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/blockpatterns

All issues in Automattic/blockpatterns

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.