Waves: Block breaks in the site editor

Open
#331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, react
Domain
frontend

Research direction

Reproduce the error by inserting the Waves block in the site editor, then start with waves.js at init (line 176) and run (line 368), followed by edit.js at line 189. Compare this path with the working frontend and post editor cases; done means the block inserts in the site editor without the unknown attachment type error.

Written by the indexing model from the issue text.

Description

Bug

I'm getting this error when inserting the waves block in the site editor. It seems to work fine in the frontend and post editor.

Uncaught Error: unknown attachment type
    createFramebufferInfo framebuffers.js:242
    createFramebufferInfo framebuffers.js:197
    init waves.js:176
    run waves.js:368
    Edit edit.js:189
    commitHookEffectListMount react-dom.js:23160
    commitPassiveMountOnFiber react-dom.js:24936
    commitPassiveMountEffects_complete react-dom.js:24901
    commitPassiveMountEffects_begin react-dom.js:24888
    commitPassiveMountEffects react-dom.js:24876
    flushPassiveEffectsImpl react-dom.js:27049
    flushPassiveEffects react-dom.js:26994
    performSyncWorkOnRoot react-dom.js:26086
    flushSyncCallbacks react-dom.js:12052
    commitRootImpl react-dom.js:26969
    commitRoot react-dom.js:26692
    finishConcurrentRender react-dom.js:25991
    performConcurrentWorkOnRoot react-dom.js:25819
    workLoop react.js:2653
    flushWork react.js:2626
    performWorkUntilDeadline react.js:2920
    <anonymous> wp-polyfill.js:1977
    run wp-polyfill.js:1953
    listener wp-polyfill.js:1964
    EventHandlerNonNull* wp-polyfill.js:2000
    __webpack_require__ wp-polyfill.js:26
    <anonymous> wp-polyfill.js:1901
    __webpack_require__ wp-polyfill.js:26
    <anonymous> wp-polyfill.js:101
    __webpack_require__ wp-polyfill.js:26
    <anonymous> wp-polyfill.js:90
    <anonymous> wp-polyfill.js:93
    <anonymous> wp-polyfill.js:2097
[framebuffers.js:242:12](webpack://twgl/src/framebuffers.js)
    createFramebufferInfo framebuffers.js:242
    forEach self-hosted:203
    createFramebufferInfo framebuffers.js:197
    init waves.js:176
    run waves.js:368
    Edit edit.js:189
    commitHookEffectListMount react-dom.js:23160
    commitPassiveMountOnFiber react-dom.js:24936
    commitPassiveMountEffects_complete react-dom.js:24901
    commitPassiveMountEffects_begin react-dom.js:24888
    commitPassiveMountEffects react-dom.js:24876
    flushPassiveEffectsImpl react-dom.js:27049
    flushPassiveEffects react-dom.js:26994
    performSyncWorkOnRoot react-dom.js:26086
    flushSyncCallbacks react-dom.js:12052
    commitRootImpl react-dom.js:26969
    commitRoot react-dom.js:26692
    finishConcurrentRender react-dom.js:25991
    performConcurrentWorkOnRoot react-dom.js:25819
    workLoop react.js:2653
    flushWork react.js:2626
    performWorkUntilDeadline react.js:2920
    apply self-hosted:2366
    <anonymous> wp-polyfill.js:1977
    run wp-polyfill.js:1953
    listener wp-polyfill.js:1964
    (Async: EventHandlerNonNull)
    <anonymous> wp-polyfill.js:2000
    __webpack_require__ wp-polyfill.js:26
    <anonymous> wp-polyfill.js:1901
    __webpack_require__ wp-polyfill.js:26
    <anonymous> wp-polyfill.js:101
    __webpack_require__ wp-polyfill.js:26
    <anonymous> wp-polyfill.js:90
    <anonymous> wp-polyfill.js:93
    <anonymous> wp-polyfill.js:2097
Dominant language
JavaScript
Stars
131
Forks
18
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/block-experiments

All issues in Automattic/block-experiments

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.