set $seconds = 0 in the batcache class and could not find 'served from batcache in xxx seconds'

Open
#59 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
memcached, php, wordpress
Domain
backend

Research direction

Start with the batcache class and the configuration shown in the issue, then reproduce the behavior with $seconds set to 0. Compare the generated, batcached, and served-from-batcache comments to determine whether the missing message is expected or indicates a bug; done means the behavior is explained and, if needed, covered by a regression test.

Written by the indexing model from the issue text.

Description

var $times   =    2; // Only batcache a page after it is accessed this many times... (two or more)
var $seconds =  0; // ...in this many seconds (zero to ignore this and use batcache immediately)

Hi, after I set $seconds = 0; I alwasy get the following comments:

generated in 0.243 seconds
64311 bytes batcached for 7200 seconds

And Never see the ‘served from batcache’ comment. Is it right? Thanks.

generated 10 seconds ago
generated in 0.124 seconds
served from batcache in 0.001 seconds
expires in 7190 seconds
Dominant language
PHP
Stars
295
Forks
102
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/batcache

All issues in Automattic/batcache

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.