Automattic/ScreenObject

Add method to dismiss Simulator request to save password

Open

#13 opened on Apr 26, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (2 forks)auto 404
good first issue

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (PR metrics pending)

Description

See logic duplicated between https://github.com/wordpress-mobile/WordPress-iOS/pull/20583 and https://github.com/woocommerce/woocommerce-ios/pull/9555.

Despite opening this issue, I'm a bit on the fence on this one. It would be handy to hide the logic away here, but at the same time it's really just a couple of lines and it might be easier to keep duplicating it across apps and let each consumer adapt its own version.

Contributor guide

Research direction
Review the duplicated code in the referenced PRs and decide whether to centralize the dismiss password save logic in ScreenObject or keep it per app. Then implement the method in ScreenObject.
Tech stack
swift
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
SwiftiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60