Offer a Suspending API for `EncryptedLogging.enqueueSendingEncryptedLogs(...)`

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
kotlin
Domain
mobile-dev

Research direction

Start by reading EncryptedLogging.enqueueSendingEncryptedLogs(...) and the appCoroutineScope.launch usage described in the issue. Trace how the API behaves for FATAL errors and determine the expected suspending entry point. Done means the limitation is addressed by a documented suspending API, with its behavior verified by the relevant tests if present.

Written by the indexing model from the issue text.

Description

enhancement

This came as an idea after working on WCAndroid#14711, where we identified a limitation of using appCoroutineScope.launch { ... } with encryptedLogging.enqueueSendingEncryptedLogs(...) for FATAL errors.

For more info see (Internal discussion): p1759832867149029-slack-CGPNUU63E

FYI: Another idea to address this issue, from a different angle, could be:

  • In case of FATAL error, store an "intent" of sending logs in the future.
  • On the next app resume, check the "intent" and collect logs then (because they’re stored now on the disk).
Dominant language
Kotlin
Stars
3
Forks
2
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/EncryptedLogging

All issues in Automattic/EncryptedLogging

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.