AudithSoftworks/Uniform

[FR] Allow adding a CSS class to field to avoid unwanted transformation

Open

#455 opened on Dec 17, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,200 stars) (346 forks)batch import
for future reconsiderationhelp wantednew feature

Description

I am the author of star-rating.js, a script that transforms a SELECT rating field into a star rating control.

I use this script in a WordPress plugin that provides ratings and reviews.

When the Uniform script is used in WordPress themes, it usually is triggered on all form fields, i.e

$("select:not([multiple]), input:checkbox, input:radio, input:file").uniform();

This makes the theme incompatible with the reviews plugin as the Uniform script adjusts the DOM which breaks the star-rating.js script. This is primarily a CSS issue as I could fix this (and likely will) by un-setting all of the CSS rules that Uniform sets on the star-rating control.

However, a far simpler solution would be for the Uniform script to check for a particular class, which if exists, would tell Uniform not to transform the element.

e.g.

<!-- Do not transform elements that have the ".browser-default" CSS class -->
<select class="browser-default"> ... </select>

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptjQuery
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the main plugin file (likely `jquery.uniform.js`) to locate where form elements are selected and transformed. Add a conditional check for a CSS class (e.g., 'browser default') to skip transformation. Since the issue has no maintainer response, ensure the change is minimal and non breaking. Consider adding documentation for the new class attribute.