timestamp unused

Open
#339 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
compilers

Research direction

Open src/arkreactor/VM/State.cpp and inspect State::configure(), especially the timestamp declaration near line 236 and its calculation near line 246. Reproduce the Linux GCC build to confirm the unused-but-set warning, then determine whether the timestamp should be used or removed. Done means the build completes without this warning.

Written by the indexing model from the issue text.

Description

❗️ priority/medium 🔥 bug 🤔 help wanted

Describe the bug

On Linux GCC Compiler we get the following warning:

[ 37%] Building CXX object CMakeFiles/ArkReactor.dir/src/arkreactor/VM/State.cpp.o
/home/runner/work/Ark/Ark/src/arkreactor/VM/State.cpp: In member function ‘void Ark::State::configure()’:
/home/runner/work/Ark/Ark/src/arkreactor/VM/State.cpp:236:21: error: variable ‘timestamp’ set but not used [-Werror=unused-but-set-variable]
236 | timestamp_t timestamp = 0;
| ^~~~~~~~~

To Reproduce
Compile on Linux using GCC

Expected behavior
There is some effort put into calculating the value of timestamp (see line 246).
So it looks like it should be used.

Additional context
This should be fixed or the variable removed.

Dominant language
C++
Stars
729
Forks
54
Avg merge
4h 8m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ArkScript-lang/Ark

All issues in ArkScript-lang/Ark

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.