AppImage/AppImageKit

Check if icons in usr/share/icons/hicolor have correct sizes

Open

#887 opened on Dec 7, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (8,239 stars) (547 forks)batch import
enhancementgood first issuepr-welcome

Description

appimagetool should exit if the AppDir contains icons in the wrong sizes in usr/share/icons/hicolor subdirectories (e.g., if usr/share/icons/hicolor/48x48/apps contains a 1024x1024 pixel image). Thjs will help to prevent situations like this:

Contributor guide

Tech stack
c
Domain
desktopclitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingFile I/OImage format basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the appimagetool source code (likely src/appimagetool.c) to find where icons are currently copied or processed. Determine how to read image dimensions from PNG and JPEG files using available libraries or system tools. Implement a function that takes the AppDir path, walks the hicolor icon directories, and for each icon file, compares its pixel size to the directory name (e.g., 48x48). If mismatch, print error and exit. Consider using libraries like libpng or libjpeg for image dimension retrieval.