AppHouseKitchen/AlDente-Battery_Care_and_Monitoring

Different charge rules and limits for wall power vs dock power

Open

#1131 opened on Dec 17, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (9,038 stars) (330 forks)batch import
enhancementhelp wanted

Description

Is your feature request related to a problem? Please describe. When I am traveling and sporadically charging from wall power, I find it more useful to set the charge limit to 100% and disable "Stop charging when sleeping". When on a desktop dock with power passthrough, I find it more useful to set the charge limit at 80% and enable "Stop charging when sleeping".

Describe the solution you'd like Set different charge rules and limits for wall power vs dock power. Dock devices may be detected.

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftmacOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The feature requires distinguishing wall power from dock power. Look into IOKit's IOPowerSources or NSWorkspace's notification for power source changes. Consider implementing a detection mechanism for dock connected devices, possibly using IO Registry. The existing charge limit logic should be extended to support profiles per power source. Check files like 'BatteryController.swift' or 'SettingsView.swift' for current charge limit implementation.