AppFlowy-IO/appflowy

[Bug] CSD GTK titlebar on GNOME does not follow dark/light theme setting

Open

#3,536 opened on Sep 26, 2023

View on GitHub
 (6 comments) (4 reactions) (0 assignees)Rust (16,871 stars) (807 forks)batch import
2024desktopgood first issue for experienced devshelp wantedimprovementslook and joyplatform-linux

Description

Bug Description

GNOME doesn't draw window decorations for native Wayland clients, so when AppFlowy runs as a native wayland client, Flutter uses GTK to draw a window decoration instead, but it seems that its theme is unaffected via org.freedesktop.appereance setting key

How to Reproduce

  1. Use GNOME on Wayland (Vanilla GNOME)
  2. Install appflowy
  3. Use appflowy
  4. Use gnome-control-center (GNOME settings) to change theme settings

Expected Behavior

For AppFlowy and CSD to go dark,

Currently, only AppFlowy goes dark, CSD titlebar stays

Operating System

Arch Linux, Freedesktop Flatpak runtime

AppFlowy Version(s)

0.3.2 (Flatpak)

Screenshots

Screencast dari 2023-09-25 01-12-36.webm

Additional Context

Also see Flutter upstream's status for org.freedesktop.appereance setting key : https://github.com/flutter/flutter/issues/92261 https://github.com/flutter/flutter/issues/135390

Contributor guide

Tech stack
flutterrust
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
FlutterLinux desktopGTK theming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate how AppFlowy's GTK titlebar theme is set. The bug suggests that the GTK titlebar does not update when the system theme changes. Check the Flutter desktop implementation and the code that handles the `org.freedesktop.appereance` setting key. See Flutter issues #92261 and #135390 for upstream context. Possibly modify the GTK window decoration to listen for theme changes and update accordingly.