AppFlowy-IO/appflowy

[Bug] Add missing Tabs hotkeys to Shortcut settings

Open

#3,393 opened on Sep 13, 2023

View on GitHub
 (13 comments) (1 reaction) (1 assignee)Rust (807 forks)batch import
2024good first issue for devsgood first issue for experienced devshacktoberfestorganizationshortcuts

Repository metrics

Stars
 (16,871 stars)
PR merge metrics
 (Avg merge 1h 18m) (1 merged PR in 30d)

Description

Bug Description

Inside appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart exists some hotkeys that are not included in the shortcut settings, and thus are not customizable.

These include some for tabs:

  • Close current tab
  • Go to next tab
  • Go to previous tab

Additionally there are some other hotkeys that should also be added:

  • Collapse sidebar menu
  • Toggle theme mode

How to Reproduce

  1. Open AppFlowy
  2. Open Settings
  3. Navigate to Shortcuts
  4. Cannot change eg. "Navigate to next tab" as it doesn't exist in the list

Expected Behavior

  1. Open AppFlowy
  2. Open Settings
  3. Navigate to Shortcuts
  4. Can change the shortcut for "Navigate to next tab"

Operating System

All

AppFlowy Version(s)

0.3.1

Screenshots

No response

Additional Context

No response

Contributor guide

Research direction
Find the file 'hotkeys.dart' and add the missing hotkeys (close tab, next tab, previous tab, collapse sidebar, toggle theme) to the shortcut settings list.
Tech stack
flutterdart
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DartFlutter
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70