AnderWeb/discreteSeekBar

Error in indicator size measurement for custom transformToString

Open

#32 opened on May 30, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (406 forks)batch import
bughelp wanted

Repository metrics

Stars
 (2,113 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using a custom string transform, the the librarys bubble measuring is wrong. I assume it is using 0 or something else to probe the size, transformToString results in.

What I was doing is I used.

@Override
public String transformToString(int value) {
    DecimalFormat speedFormat = new DecimalFormat("#.##");
    float speed = value / 1000F;
    return speedFormat.format(value) + "x";
}

But set the minimum to 500 and the maxium to 2000. The result was the text being cropped. I assume that the library probes for a 0, which led to a result of x for my app. And that the library used the x as the bounds size for the bubble. A good fix would be to use the mMax value to probe for the size. A workaround I impemented was to use:

if (value < internalMin)
    value = internalMax;

inside

transformToString(int value)

That way the correct measurement is ensured.

Contributor guide

Research direction
Investigate the bubble size measurement code in the library. Trace where the size probe value is set; it likely defaults to 0. Change it to use the maximum value (mMax) to get accurate text bounds for custom transformToString implementations.
Tech stack
java
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75