AnSavvides/d3act

Bubble chart text min value

Open

#29 opened on Mar 1, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (300 stars) (26 forks)batch import
enhancementhelp wanted

Description

The bubble chart needs to have a value bigger than 15 to display text. This value is too random, should not this be a prop?

https://github.com/AnSavvides/d3act/blob/master/src/components/BubbleChart.js#L15

Contributor guide

Tech stack
javascriptreact
Domain
frontenddata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React knowledgefamiliarity with props
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate src/components/BubbleChart.js line 15 to find the hardcoded threshold value 15. Determine how to add a new prop (e.g., minTextValue) with a default value of 15. Ensure the prop is documented and added to propTypes. Test that the chart uses the prop instead of the hardcoded value.