Installer telemetry tests assert source text rather than execution

Open
#1,228 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
78/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
cli, testing-qa

Research direction

Start with packages/opencode/test/install/install-telemetry.test.ts:35-58 and read its header comment. Compare those assertions with the spawnSync-based tests elsewhere in the same file, then run the installer telemetry tests. Done means the tests execute the installer and detect behavioural changes rather than only matching source text.

Written by the indexing model from the issue text.

Description

Deferred from the v0.10.0 release review. The gap is disclosed in the test file's own header comment.

packages/opencode/test/install/install-telemetry.test.ts:35-58 asserts against the installer script's source text with regexes rather than executing it. That is weaker than the spawnSync-based tests elsewhere in the same file: a refactor that preserves behaviour but changes wording fails, and one that changes behaviour while preserving wording passes.

Dominant language
TypeScript
Stars
813
Forks
134
Avg merge
2d 5h
Merged PRs (30d)
62

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AltimateAI/altimate-code

All issues in AltimateAI/altimate-code

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.