chore: re-enable [10/10] no-internet models.dev sanity test once soaked
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- shell, typescript
- Domain
- networking, testing-qa
Research direction
After v0.9.7 has been live for a cycle, read the D14 fix in 205a953d62 and inspect ModelsDev.Data() and fetchApi() to confirm the no-internet path is safe. Run test/sanity/phases/resilience.sh and re-enable the [10/10] no-internet graceful handling test if the soak is clean; done means the test passes without an internet connection.
Written by the indexing model from the issue text.
Description
Follow-up from the D14 fix in 205a953d62 (#1085), noted again during v0.9.7 release review (CTO persona).
The eager import-time ModelsDev.refresh() fetch was removed to fix a CI hang (unshare --net blocked DNS resolution past process exit). However, ModelsDev.Data() still falls through to the same unbounded fetchApi() whenever both the disk cache and the bundled snapshot are absent — true in dev-mode builds without the embedded snapshot. The reduction is real but not a full close.
test/sanity/phases/resilience.sh's [10/10] no-internet graceful handling test remains SKIPPED pending 'soak through one release' per the original commit message. Re-evaluate re-enabling it after v0.9.7 has been live for a cycle.
- Dominant language
- TypeScript
- Stars
- 813
- Forks
- 134
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 62
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AltimateAI/altimate-code
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
AltimateAI/altimate-code#1323 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
AltimateAI/altimate-code#1288 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
AltimateAI/altimate-code#1285 ·
-
privacy: Altimate Base consent dialog no longer discloses persistent per-installation identifier Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
AltimateAI/altimate-code#1284 ·
-
Difficulty 2/5 Under an hour Newbie friendliness 72/100
AltimateAI/altimate-code#1283 ·
All issues in AltimateAI/altimate-code
Similar issues
-
Browser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
getsentry/sentry-javascript#24577 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
agilepathway/label-checker#640 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
copse-dev/agent-pane#2953 ·
-
agentic-workflows
Difficulty 1/5 Under an hour Newbie friendliness 85/100
githubnext/rig#534 ·
-
automation missing-model model-sync provider:pioneer
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
anomalyco/models.dev#7701 ·