fix(core): grep skip counts/reasons not surfaced to caller or user
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- tooling
Research direction
Read packages/core/src/ripgrep.ts and packages/opencode/src/tool/grep.ts, tracing how grep() computes skipped and how Match[] reaches the tool caller. Decide how the skip count and any sample of reasons should cross that boundary, then ensure non-zero skips produce a one-line note so partial results are visible to the caller and user.
Written by the indexing model from the issue text.
Description
Found during v0.9.7 release review (End User persona), building on the ripgrep record-isolation fix in ca9b34a523 (#1094).
grep() in packages/core/src/ripgrep.ts computes a skipped tally for a single aggregate Effect.logWarning, but the return value consumed by packages/opencode/src/tool/grep.ts is just Match[] — the skip count/reasons never reach the tool caller or the user.
Risk: a tree with many corrupted/oversized/non-UTF-8 files (or a systematic issue) now returns a partial result that reads exactly like an honest 'no matches' to both agent and user, with the only trace in a debug log almost nobody opens. This is the same class of silent-data-loss bug #1094 was written to fix, just one layer further out.
Suggested fix: thread the skip count (and maybe a sample of skip reasons) through to the tool result, surfaced as a one-line note when non-zero (e.g. 'N records skipped due to encoding/size issues').
- Dominant language
- TypeScript
- Stars
- 813
- Forks
- 134
- Avg merge
- 2d 8m
- Merged PRs (30d)
- 65
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AltimateAI/altimate-code
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
AltimateAI/altimate-code#1359 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
AltimateAI/altimate-code#1323 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
AltimateAI/altimate-code#1288 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
AltimateAI/altimate-code#1285 ·
Maintainers usually reply within 1 day
-
privacy: Altimate Base consent dialog no longer discloses persistent per-installation identifierOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
AltimateAI/altimate-code#1284 ·
Maintainers usually reply within 1 day
All issues in AltimateAI/altimate-code
Similar issues
-
check:passed streams:add
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Fission-AI/OpenSpec#1986 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nestjs/docs.nestjs.com#3554 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
publicodes/publicodes#868 ·
-
namespace operations
Difficulty 1/5 Under an hour Newbie friendliness 78/100
EclipseFdn/open-vsx.org#13488 ·
Maintainers usually reply within 2 days