Remove wrapping div from live region

Open Beginner friendly
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript, react

Research direction

The issue identifies the Announcer component and the rendered message block; start there by inspecting its current JSX. Done means the live-region messages render without the needless wrapping div, using a Fragment instead.

Written by the indexing model from the issue text.

Description

good first issue

Currently the Announcer component still has a needless wrapping div being rendered in the DOM:

      <div>
        <MessageBlock aria-live="assertive" message={assertiveMessage1} />
        <MessageBlock aria-live="assertive" message={assertiveMessage2} />
        <MessageBlock aria-live="polite" message={politeMessage1} />
        <MessageBlock aria-live="polite" message={politeMessage2} />
      </div>

This should be replace with a Fragment.

Dominant language
JavaScript
Stars
205
Forks
26
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AlmeroSteyn/react-aria-live

All issues in AlmeroSteyn/react-aria-live

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.