AllenFang/react-bootstrap-table

Add animations with react-flip-move

Open

#981 opened on Jan 22, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (795 forks)batch import
help wanted

Repository metrics

Stars
 (2,240 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I use react-flip-move as a drop in replacement for my tables to create easy animations. It's easy enough to modify existing code that already builds tables in react by replacing the element with

<table>
  <FlipMove typeName='tbody'>
    {this.renderRows()}
  </FlipMove>
</table>

I believe the easiest to add this functionality would be the ability to pass in a wrapper object that react-bootstrap-table would use to replace the tbody element that react-bootstrap-table creates, but the API doesn't currently allow this.

Does this approach seem correct?

Contributor guide

Research direction
Implement a prop to allow replacing the tbody element with a custom wrapper component, such as react flip move's FlipMove, to enable animations.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70