AllenFang/react-bootstrap-table

Extend filters to allow html attributes to be passed down

Open

#1715 opened on Oct 26, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,240 stars) (795 forks)batch import
help wantedin progress

Description

Hello. Currently it appears there is no way to add an html attribute to the underlying markup that is generated by the built-in filters such as <SelectFilter>.

My use-case would be adding an id, data, or aria attribute to the html elements such as a <select>.

Attributes are passed to the component in the JSX. https://github.com/AllenFang/react-bootstrap-table/blob/281db991c08f1d4cad2c522b13875a97d2e27e0f/src/TableHeaderColumn.js#L70

But they aren't shared with the HTML elements. https://github.com/AllenFang/react-bootstrap-table/blob/281db991c08f1d4cad2c522b13875a97d2e27e0f/src/filters/Select.js#L98-L104

I'm happy to submit a PR if you agree with the use.

Contributor guide

Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic ReactProps passing in React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the source files: src/TableHeaderColumn.js and src/filters/Select.js. In Select.js, the component currently renders a <select> element with specific props; add a prop like `htmlAttributes` or simply spread additional props onto the <select>. Ensure that tests are updated. Also check if similar filters need the same treatment. Since the author offered a PR, coordinate with maintainers for guidance.