AllenFang/react-bootstrap-table

Performance issue sizePerPageList

Open

#1241 opened on Apr 20, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,240 stars) (795 forks)batch import
help wanted

Description

I have a table with drop-downs , text-areas,check-box so its taking time to load if the number of rows are more than 1000 rows.

Regarding the issue , if i have number of records 2000 and my sizeperpagelist drop down has values 10,25,100,200,all. When i select All , it takes time to render the table , Will you be able to add a spinner on change of drop-down and keep it untill it rerender. I can write the custom code and add spinner but i am not sure when its get rerendered .

Hope you understood my issue . let me know if you have any questions on it .

Contributor guide

Tech stack
javascriptreactcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of React lifecyclereact bootstrap table API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests adding a spinner when changing the sizePerPageList dropdown, particularly when selecting 'All' with a large number of rows. To implement this, one would need to understand the rendering flow of the table component, likely in the code handling page size changes. Look at the component that processes sizePerPage and triggers re render. A spinner could be added by setting a loading state before the update and clearing it after re render. The maintainer has not responded, so the acceptance criteria are unclear. Check the repository's source code, especially files related to pagination and the sizePerPageList prop.