The tagged skills test sleeps through attachment instead of waiting for the chip
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- go
- Domain
- testing-qa
Research direction
Start in internal/e2e/skills_e2e_test.go at lines 92 and 98, and compare the attach arm of TestSkillsE2E with its existing r.waitFor usage for the picker row. Run go test -tags e2e -run TestSkillsE2E ./internal/e2e/ with a delayed attach response. Done means the test waits for the attached chip or named refusal, waits for the cleared editor, and has no fixed post-attach sleeps in that scenario.
Written by the indexing model from the issue text.
Description
Found on santos/dev2 at 008363c98 (#1410). It reaches dev when #1410 merges.
What happened
The tagged skills e2e waits 700 ms after Enter and another 500 ms after clearing the box. Neither pause proves that the skill chip appeared. On a slow machine the test can type its next question before attachment settles; on a fast one it wastes time. No failure from this timing was observed.
Replication
Deterministic (no model). Read the attach arm of TestSkillsE2E: after r.keys("Enter") it uses fixed sleeps, then checks only for a refusal and proceeds. A delayed fake attach response longer than 700 ms makes the check run before the chip appears.
Where
internal/e2e/skills_e2e_test.go:92 and :98 contain the fixed sleeps at 008363c98; the same test already uses r.waitFor to wait for the picker row.
The fix
Wait for the attached chip or a named refusal, then wait for the cleared editor state before typing the question. Use the suite's bounded screen wait.
Acceptance
- e2e:
go test -tags e2e -run TestSkillsE2E ./internal/e2e/asserts the chip before its next message and passes with a delayed attach response. - Unit: no fixed post-attach sleeps remain in that scenario.
- The test change entry's
invalidatesnames the former timing assumption.
- Dominant language
- Go
- Stars
- 115
- Forks
- 14
- Avg merge
- 9h 38m
- Merged PRs (30d)
- 749
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Agent-Field/CodeAF
-
area:chat feature
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Agent-Field/CodeAF#1510 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Agent-Field/CodeAF#1489 ·
Maintainers usually reply within 1 day
-
area:chat bug good first issue sev:papercut
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Agent-Field/CodeAF#1470 ·
Maintainers usually reply within 1 day
-
area:chat bug good first issue sev:papercut
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Agent-Field/CodeAF#1469 ·
Maintainers usually reply within 1 day
-
area:chat bug sev:papercut
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Agent-Field/CodeAF#1468 ·
Maintainers usually reply within 1 day
All issues in Agent-Field/CodeAF
Similar issues
-
enhancement low priority
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
eugenioenko/ttt#674 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
GoogleCloudPlatform/k8s-config-connector#13462 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
vavallee/bindery#2793 · 1 comment ·
Maintainers usually reply within 1 day