FundingSourceEnum missing `DEFFERED_DEBIT` value returned by POS terminals

Open Beginner friendly
#1,878 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
payments

Research direction

Start at com.adyen.model.checkout.CardDetails.FundingSourceEnum and inspect its fromValue() handling for the POS response value DEFFERED_DEBIT. Check the existing enum tests or add coverage for parsing this value, then verify that valid terminal responses no longer raise the reported exception.

Written by the indexing model from the issue text.

Description

Bug report do not stale

When processing payment responses from Adyen POS terminals, the additionalData.fundingSource field can return DEFFERED_DEBIT, which is not present in com.adyen.model.checkout.CardDetails.FundingSourceEnum.

The current enum only contains: CREDIT, DEBIT, PREPAID.

This causes FundingSourceEnum.fromValue() to throw an exception for a valid terminal funding source, resulting in errors like:

fundingType unknown: AdditionalResponse[additionalData=AdditionalData[fundingSource=DEFFERED_DEBIT, acquirerResponseCode=00 : Approved or completed successfully, cardScheme=visastandardcredit, applicationLabel=Visa, ...]]

Could the enum be extended to cover this value, or is there some other enum for webhook parsing?

Dominant language
Java
Stars
148
Forks
158
Avg merge
3d 3h
Merged PRs (30d)
10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Adyen/adyen-java-api-library

All issues in Adyen/adyen-java-api-library

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.