ACF Pro: package's composer.json says name "wpengine/advanced-custom-fields", not "...-pro"

Open Beginner friendly
#1,014 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
php, wordpress
Domain
release

Research direction

Start by inspecting the composer.json included in the ACF Pro 6.8.1 build and compare its declared package name with the distributed Composer name. Verify that the Pro package declares wpengine/advanced-custom-fields-pro while retaining replacement compatibility for the free package, then confirm the resulting metadata supports the reported Composer workflow.

Written by the indexing model from the issue text.

Description

composer require wpengine/advanced-custom-fields-pro installs fine from connect.advancedcustomfields.com. But the package it pulls down declares this in its own composer.json:

{
    "name": "wpengine/advanced-custom-fields",
    "type": "wordpress-plugin"
}

So the name inside the package doesn't match the name you distribute it under.

It bites going the other way. I'm migrating sites to a Composer-managed setup, so I read each installed plugin's composer.json to work out what to require. For ACF Pro that gives me wpengine/advanced-custom-fields, which isn't installable, so I special-case it back to -pro.

Any chance the Pro build could declare wpengine/advanced-custom-fields-pro in composer.json? Keeping the replace on the free name would avoid breaking anything else.

(Seen on 6.8.1.)

Dominant language
PHP
Stars
945
Forks
197
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AdvancedCustomFields/acf

All issues in AdvancedCustomFields/acf

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.