Update Lifecycle direct extension's configuraiton keys to include the data type required

Open Beginner friendly
#797 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
swift
Domain
documentation

Research direction

Start with the Lifecycle configuration keys page linked in the issue and review how the session timeout key is documented. Update the documentation to state that its value must be an integer, and clarify the value expected by the Lifecycle extension. Done when users can identify the required data type from the page.

Written by the indexing model from the issue text.

Description

edgesquad
Is there an existing issue for this?
  • I have searched the existing issues
What's missing?

Current docs don't explain that the data type should be an int:
https://developer.adobe.com/client-sdks/home/base/mobile-core/lifecycle/configuration-keys/

and since a lot of config keys are strings, and the casting failure is silent, it's not obvious what value is being used:

private func getSessionTimeoutLength(configurationSharedState: [String: Any]?) -> TimeInterval {
        guard let sessionTimeoutInt = configurationSharedState?[LifecycleConstants.EventDataKeys.CONFIG_SESSION_TIMEOUT] as? Int else {
            return TimeInterval(LifecycleConstants.DEFAULT_LIFECYCLE_TIMEOUT)
        }

        return TimeInterval(sessionTimeoutInt)
    }
Dominant language
JavaScript
Stars
6
Forks
54
Avg merge
1d 19h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AdobeDocs/aep-mobile-sdkdocs

All issues in AdobeDocs/aep-mobile-sdkdocs

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.