Prefer not operator

Open Beginner friendly
#125 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Domain
build-system

Research direction

Open gpr/src/gpr-nmsc.adb at the linked line around 743 and inspect the existing condition. Replace the condition with the proposed not operator form, then review the surrounding Ada formatting and behavior to confirm the change is equivalent.

Written by the indexing model from the issue text.

Description

Dear Gprbuild developers,

Why not replace
https://github.com/AdaCore/gprbuild/blob/1e13ed644c71509a0a6b8cd3102d88cedb59cf88/gpr/src/gpr-nmsc.adb#L743

with

         if not (Add_Src) then

Greetings,
Pierre

Problem detected and solved by Rejuvenation-Ada crate
vote for Rejuvenation-Ada as The 2022 Ada Crate Of The Year

Dominant language
Ada
Stars
81
Forks
24
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AdaCore/gprbuild

All issues in AdaCore/gprbuild

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.