OSL mx_geompropvalue_filename never returns the geomprop value

Open Beginner friendly

#3,003 opened on Jul 10, 2026 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 1/5
Estimated time: Under an hour
Newbie friendliness: 85/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Active
Domain: computer-graphics

Research direction

Open libraries/stdlib/genosl/mx_geompropvalue_filename.osl and inspect the getattribute condition in mx_geompropvalue_filename. Verify the success and failure paths, then correct the condition so the geomprop filename replaces the default only when the attribute is found; done means the found value is returned and the default remains otherwise.

Written by the indexing model from the issue text.

Description

https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/stdlib/genosl/mx_geompropvalue_filename.osl

I'm no OSL expoert, but it appears as though the found geomprop is only assigned when it is not found, i.e. it's never assigned:

void mx_geompropvalue_filename(string geomprop, textureresource defaultVal, output textureresource out)
{
    // Initialize to the default
    out = defaultVal;

    // Replace the filename component from the geomprop
    string defaultFilename = defaultVal.filename;
    if (getattribute(geomprop, defaultFilename) == 0)   // <--- this should be == 1 I think?
        out.filename = defaultFilename;
}

Dominant language: C++
Stars: 2.3k
Forks: 464
Avg merge: 4d 13h
Merged PRs (30d): 13

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug] NULL pointer dereference in llm_running_callback (NGZA-AX-LLM #3) Open

Difficulty 1/5 Under an hour Newbie friendliness 90/100

AXERA-TECH/ax-llm#77 · Opened Sep 22, 2026
resume() sends a second HTTP response (400) after a successful resume Open

Difficulty 1/5 Under an hour Newbie friendliness 90/100

games-on-whales/wolf#509 · Opened Sep 21, 2026
pn7160: reader goes permanently deaf — post-read IRQ-low check fails reads that succeeded Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

esphome/esphome#19452 · Opened Sep 21, 2026
Eval bug: Ministral-3 tool-calls during reasoning are not processed Open

bug-unconfirmed

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

ggml-org/llama.cpp#29248 · Opened Sep 21, 2026
run_tests.py fails on windows, but running tests individually works Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

NVIDIA/cuda-samples#453 · Opened Sep 21, 2026

More C++ issues