SonarCloud Analysis broken by recent update to sonar-scanner

Open Beginner friendly
#374 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
github-actions
Domain
ci-cd

Research direction

Open analysis_workflow.yml and inspect the sonar-scanner command and its existing SONAR_TOKEN environment variable. Remove the deprecated CLI parameter as described in the issue, then run the SonarCloud analysis workflow and confirm that results upload successfully.

Written by the indexing model from the issue text.

Description

SonarCloud analysis for Imath last succeeded in uploading results on 2024-01-13:

https://sonarcloud.io/project/overview?id=AcademySoftwareFoundation_Imath

The issue seems to be caused by the deprecation of the sonar.login parameter:

https://github.com/AcademySoftwareFoundation/Imath/actions/runs/7945143614/job/21691431831

00:27:48.413 WARN: The property 'sonar.login' is deprecated and will be removed in the future. Please use the 'sonar.token' property instead when passing a token.

The documentation as well as OpenImageIO's analysis workflow indicates that it isn't necessary to set the token on the CLI, it should be sufficient to set the SONAR_TOKEN environment variable which analysis_workflow.yml already does.

Removing -Dsonar.login=$SONAR_TOKEN from the sonar-scanner command line should hopefully be sufficient to restore the functionality of uploading results back to the SonarCloud site.

A similar issue exists for OpenEXR, issue 1646.

Dominant language
C++
Stars
488
Forks
161
Avg merge
43m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AcademySoftwareFoundation/Imath

All issues in AcademySoftwareFoundation/Imath

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.