AFLplusplus/LibAFL

Potential Undefined Behavior in Frida ASan

Open

#1,862 opened on Feb 15, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (476 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (2,584 stars)
PR merge metrics
 (PR metrics pending)

Description

In asan_rt.rs, we're getting mutable references to self at various places, hereby creating aliases for mutable references. This is not permitted in Rust and may break in the future, see here: https://github.com/AFLplusplus/LibAFL/blob/97a83aba3bc6376786984efde3e4a968fe553068/libafl_frida/src/asan/asan_rt.rs#L1945C42-L1945C46 Instead, we probably need to store the runtime on the heap and keep a pointer to it (Rc, UnsafeCell, Pin, or something like that?)

Contributor guide

Research direction
Identify all locations in asan rt.rs where mutable references to self are aliased, and propose a fix using heap allocation with Rc, UnsafeCell, or Pin to avoid undefined behavior.
Tech stack
rust
Domain
security
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50