ACloudGuru/serverless-plugin-aws-alerts

Cannot update existing alarms with new default function invocations values

Open

#118 opened on Apr 23, 2020

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (150 forks)auto 404
buggood first issue

Repository metrics

Stars
 (523 stars)
PR merge metrics
 (PR metrics pending)

Description

This is a Bug Report

Description

custom:
  alerts:
    topics:
      alarm:
        topic: uclusion-summaries-${opt:stage, self:provider.stage}-alerts-alarm
        notifications:
          - protocol: email
            endpoint: support@uclusion.com
    definitions:
      functionInvocations:
        evaluationPeriods: 60
        datapointsToAlarm: 10
    alarms:
      - functionErrors
      - functionThrottles

Alarms were created fine initially but later added the functionInvocations section and that had no effect For bug reports:

  • What went wrong? Update of the alarms with the new defaults did not happen.

  • What did you expect should have happened? That the alarms would have the new defaults for evaluationPeriods and datapointsToAlarm

  • What was the config you used? See above.

  • What stacktrace or error message from your provider did you see? None

  • Similar or dependent issues: Didn't see any

Contributor guide

Research direction
Investigate how the plugin updates existing alarms when new default function invocations values are added. Look for code that compares current alarm state with desired state, and find where the update logic might be missing for new definitions.
Tech stack
javascriptnodejsaws
Domain
devopscloudbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Serverless FrameworkNode.jsAWS CloudWatch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75