89luca89/terrible

[IMPROVEMENT] Improve Asserts

Open

#87 opened on Jul 4, 2021

View on GitHub
 (3 comments) (0 reactions) (1 assignee)YAML (29 forks)github user discovery
bugenhancementexperimentalhelp wanted

Repository metrics

Stars
 (259 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Some assertions should be improved, for example:

            host-vm-1:
              disk_source: "/mnt/iso/debian10-terraform.qcow2"
              os_family: Debian
              cpu: 1
              memory: 512
              hypervisor: hypervisor_1
              ansible_host: 192.168.122.9
              network_interfaces:
                iface_1:
                  name: default
                  type: nat
                  ip: 192.168.122.9
                  gw: 192.168.122.1
                  dns:
                    - 192.168.122.1
              default_route: True <<<--- note this is unindented

This snippets passes the assertions even if it's not valid We should review and evaluate more corner cases to include in the assertions

Also we could think of an external tool/linter as @alegrey91 suggests to validate inventories

Contributor guide

Research direction
Review the current assertion code and identify gaps in YAML validation. Consider adding checks for indentation and structure. Evaluate potential use of external linters like yamllint.
Tech stack
None
Domain
testingdevops
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
YAMLAnsible
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65