Visited Style: float not removing underline in Firefox

Open Beginner friendly
#5 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Domain
frontend

Research direction

The issue is in the 'Visited Style' demo at https://smolcss.dev/#smol-visited-styles. Look at the CSS for the icon span where float: left is applied to remove the underline. Test in Firefox on macOS to see the underline persists. Investigate alternative CSS properties like display: inline-block or text-decoration-skip-ink to fix the cross-browser issue. Check the project's CSS files for the demo snippet to make the change.

Written by the indexing model from the issue text.

Description

In the code-example you add float: left to the icon-<span> to remove underline from it.
https://smolcss.dev/#smol-visited-styles

This is not working with (at least) recent Firefox (on Mac OS).

screenshot from smolcss demo showing the unwanted underline under the icon

Dominant language
Nunjucks
Stars
840
Forks
13
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from 5t3ph/smolcss

All issues in 5t3ph/smolcss

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.