Add 'proficiency' property to subclass object

Open Beginner friendly
#258 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Domain
database

Research direction

Look at the subclass data structure in the repository, likely in a JSON file for cleric domains. Identify where subclass objects are defined and add a 'proficiencies' property. Check existing examples of proficiency data elsewhere in the database to understand the format. Verify the change by reviewing the data consistency and possibly running any validation scripts.

Written by the indexing model from the issue text.

Description

So

When you choose life domain for cleric, you get proficiency with heavy armor, but it is not specified in data itself, you just get a feature called "bonus proficiency", which itself is not too descriptive.

My suggestion is, maybe add proficiencies property to domain object? And add such property to aby subclass giving you proficiencies?

Dominant language
TypeScript
Stars
939
Forks
428
Avg merge
21h 18m
Merged PRs (30d)
18

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from 5e-bits/5e-database

All issues in 5e-bits/5e-database

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.