macOS: terminal-launch Clippy fails on unnecessary tail return
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
Research direction
Start with crates/jcode-terminal-launch/src/lib.rs:269–273 in detected_resume_terminal_with_client_env and run the provided scripts/dev_cargo.sh clippy command on macOS. Check the platform-specific match and preserve its arms, cfg boundaries, and non-macOS behavior while making the package-level lint check pass without suppressing warnings.
Written by the indexing model from the issue text.
Description
Summary
On macOS, the terminal-launch library fails Clippy with warnings denied because the final platform-specific match uses an unnecessary return.
Reproduction
Revision: 5cb7b3dad6029a6f868e36fd4c13cbd07d1fca50 on upstream master.
Environment: macOS, Apple Silicon, Rust 1.94.1.
scripts/dev_cargo.sh clippy --offline --locked -p jcode-terminal-launch --lib -- -D warnings
Actual: exit 101, clippy::needless_return at crates/jcode-terminal-launch/src/lib.rs:269–273, in detected_resume_terminal_with_client_env.
Expected: this package-level lint check succeeds without suppressing warnings.
Proposed fix
Make the macOS match the block's tail expression by removing return and its trailing semicolon. Keep the match arms, cfg boundaries, and non-macOS behavior unchanged. This is a behavior-preserving lint correction, not a reported terminal-launch runtime failure.
A bounded search for needless_return terminal found no existing focused open fix. PR #1293 records the same lint as an unrelated upstream baseline blocker, but does not change this code.
- Dominant language
- Rust
- Stars
- 19.9k
- Forks
- 2.3k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 29
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from 1jehuang/jcode
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
OrcaRouter is in the login catalog but has no ProviderChoice, so it can't be selected explicitly Open
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
-
Session::save() skips untouched sessions, so is_debug and canary never persist (4 failing tests) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
area: providers autonomous: clear bug triage: reproducible
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
bug triage:deciding
Difficulty 1/5 Under an hour Newbie friendliness 88/100
open-telemetry/otel-arrow#4132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100