123ishaTest/ludiek

[Currency] Improve CurrencyPlugin to deal better with duplicate currencies

Open

#61 opened on Jul 26, 2025

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (4 forks)auto 404
good first issueplugin

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

The CurrencyPlugin provides helper method that deal with lists of currencies. However this could lead to the following odd scenario

const currency = new CurrencyPlugin([{ id: 'money' }]);
currency.gainCurrency({ id: 'money', amount: 1 });

const isPaid = currency.payCurrencies([
  { id: 'money', amount: 1 },
  { id: 'money', amount: 1 },
]);

console.log(isPaid); // true
console.log(currency.getBalance('money')); // -1

We could merge these lists together with a new simplifyCurrencyList function before checking, so it becomes

[{ id: 'money', amount: 2 }]

Contributor guide

Research direction
Implement a function to merge duplicate currency entries in a list, then use it before checking payments.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70